Skip to content

drivers/slipdev: implement NETDEV_EVENT_TX_COMPLETE event#20975

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/slipdev-tx_done
Nov 12, 2024
Merged

drivers/slipdev: implement NETDEV_EVENT_TX_COMPLETE event#20975
benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco:drivers/slipdev-tx_done

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

Contribution description

This appears to be required with gnrc_netif_pktq - it does not fix the memory leak though 😕

Testing procedure

The NETOPT_TX_END_IRQ not implemented by driver warning is no longer being printed.

Issues/PRs references

@benpicco benpicco requested a review from miri64 as a code owner November 11, 2024 18:19
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Nov 11, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 11, 2024
@riot-ci
Copy link
Copy Markdown

riot-ci commented Nov 11, 2024

Murdock results

✔️ PASSED

1227581 drivers/slipdev: implement NETDEV_EVENT_TX_COMPLETE event

Success Failures Total Runtime
10214 0 10215 14m:31s

Artifacts

@maribu maribu enabled auto-merge November 11, 2024 19:25
@maribu maribu added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@maribu maribu added this pull request to the merge queue Nov 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2024
@benpicco benpicco added this pull request to the merge queue Nov 11, 2024
Merged via the queue into RIOT-OS:master with commit d141c17 Nov 12, 2024
@benpicco benpicco deleted the drivers/slipdev-tx_done branch November 12, 2024 13:14
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants