cpu/cc2538: use RX FIFO count to determine CRC OK location#20956
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Nov 8, 2024
Merged
cpu/cc2538: use RX FIFO count to determine CRC OK location#20956maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Platform: ARM
benpicco
added
the
CI: ready for build
maribu
approved these changes
Nov 8, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
Thx for fixing this and welcome to the RIOT community.
I have not tested the fix, but the code changes makes a lot of sense and match the doc:
#define RFCORE_XREG_RXFIFOCNT 0x4008866C // Number of bytes in RX FIFO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Instead of using the length byte from a received packet (that might be corrupted), use the number of bytes in the RX FIFO to determine the location of the CRC OK bit.
Testing procedure
Flashed this change on two CC2538s, started ping while under heavy Wi-Fi interference. In the case where the old
pkt_lenwas not equal to the newcrc_loc, the error from #20955 did not appear. Also, the reportedpkt_lenin this case is alwayscrc_loc + 128, indicating that the receiver actually only uses the 7 LSBs from the length byte.Issues/PRs references
Fixes #20955.