sys/usb: Use luid_base for stable USB serials#20944
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Oct 29, 2024
Merged
Conversation
github-actions
bot
added
Area: USB
maribu
added
Type: enhancement
Member
Author
|
Let's not call this one a breaking API change: Before, the USB serial was not stable anyway, so changing this with this PR is not yielding unexpected behavior. |
benpicco
reviewed
Oct 28, 2024
This is useful when having multiple instances of the same board connected via USB CDC ACM and telling the TTYs apart.
maribu
force-pushed
the
sys/usbus/stable-ids
branch
from
78a6a5b to
6b80a1a
Compare
github-actions
bot
added
Area: USB
maribu
changed the title
benpicco
approved these changes
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This uses
luid_base()instead ofluid_get()to create USB serials in a stable manner. This is useful when having multiple instances of the same board connected via USB CDC ACM and telling the TTYs apart.Testing procedure
Two instances of the same board using CDC ACM as default stdio should (if they do have decent CPU IDs) now yield serials that only depend on the board and not on the app flashed.
Issues/PRs references
None