sys/chunked_ringbuffer: let crb_end_chunk() return size of the chunk#20942
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom Jan 29, 2025
Merged
Conversation
benpicco
changed the title
crb_end_chunk() return size of the chunk
benpicco
added
the
CI: ready for build
Contributor
|
Oh, but there's a merge conflict, would you mind rebasing @benpicco ? |
benpicco
force-pushed
the
sys/chunked_ringbuffer-return_size
branch
from
1b4e1af to
3429621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
It can be handy to know the size of the chunk that we just stored. Since we already have that information, it's very cheap to return that instead of
true.Testing procedure
Technically an API change, but now we already returned 0 in the error case and 1 on success, so changing bool -> int won't need any code changes.
Issues/PRs references