Skip to content

sys/posix/pthread: Add pthread_attr_getstack and pthread_attr_setstack#20934

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
LasseRosenow:pthread-attr-setstack
Oct 29, 2024
Merged

sys/posix/pthread: Add pthread_attr_getstack and pthread_attr_setstack#20934
benpicco merged 1 commit intoRIOT-OS:masterfrom
LasseRosenow:pthread-attr-setstack

Conversation

@LasseRosenow
Copy link
Copy Markdown
Member

@LasseRosenow LasseRosenow commented Oct 22, 2024

Contribution description

This adds the missing pthread_attr_setstack and pthread_attr_getstack functions to the posix-pthread wrappers.

Motivation

'pthread_attr_setstackaddr' and pthread_attr_getstackaddr are deprecated and it is recommended to use use pthread_attr_getstack and pthread_attr_setstack instead.

@github-actions github-actions bot added the Area: sys Area: System label Oct 22, 2024
benpicco
benpicco reviewed Oct 22, 2024
View reviewed changes
@LasseRosenow LasseRosenow force-pushed the pthread-attr-setstack branch from e01140c to a923ea4 Compare October 22, 2024 12:33
benpicco
benpicco reviewed Oct 22, 2024
View reviewed changes
@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 29, 2024 •
edited
Loading

Okay I have updated the code to just internally use the existing pthread_attr_getstackaddr, pthread_attr_getstacksize, pthread_attr_setstackaddr and pthread_attr_setstacksize functions.
I think this is more reasonable

benpicco
benpicco approved these changes Oct 29, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@benpicco benpicco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed a much simpler addition now and avoids code duplication.

Please squash!

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 29, 2024
@LasseRosenow LasseRosenow force-pushed the pthread-attr-setstack branch from 5d67ccb to 459b8dc Compare October 29, 2024 13:30
@LasseRosenow
Copy link
Copy Markdown
Member Author

LasseRosenow commented Oct 29, 2024

Done :)

@riot-ci
Copy link
Copy Markdown

riot-ci commented Oct 29, 2024

Murdock results

✔️ PASSED

459b8dc sys/posix/pthread: Add pthread_attr_getstack and pthread_attr_setstack

Success Failures Total Runtime
10215 0 10215 17m:12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Oct 29, 2024
Merged via the queue into RIOT-OS:master with commit 1fc9d1b Oct 29, 2024
@LasseRosenow LasseRosenow deleted the pthread-attr-setstack branch October 30, 2024 08:25
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benpicco benpicco benpicco approved these changes

Assignees

No one assigned

Labels

Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2025.01

Development

Successfully merging this pull request may close these issues.

4 participants

@LasseRosenow @riot-ci @benpicco @MrKevinWeiss