drivers/dht: fix null deref with saul#20927
Merged
mguetschow merged 2 commits intoRIOT-OS:masterfrom Oct 21, 2024
Merged
Conversation
mguetschow
requested changes
Oct 21, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing, and welcome to the project 🎉
Would you mind updating the function documentation in drivers/include/dht.h to mention the option of passing NULL if not interested, and adding a call doing that to test/drivers/dht/main.c?
mguetschow
added
the
CI: ready for build
Contributor
Author
Sure! This is done in 7c68f00 |
mguetschow
approved these changes
Oct 21, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Perfect, looks good then! Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The SAUL interface exposes two sensors for humidity and temperature, while the internal
dhtdriver exposes a singledht_readfunction with two pointers to store humidity and temperature results. The SAUL wrappers pass NULL for the value they're not interested in, butdht_readdoes not check for that and tries to store both values all the time, causing a segfault.Testing procedure
The initial bug and its fix have been observed with a DHT11 on a Wemos D1 Mini with the
saulshell command.Issues/PRs references
N/A