cpu/esp32: Improve error descriptions#20914
Merged
benpicco merged 2 commits intoRIOT-OS:masterfrom Oct 16, 2024
Merged
Conversation
AnnsAnns
requested review from
bergzand,
gschorcht and
kaspar030
as code owners
github-actions
bot
added
Platform: ARM
gschorcht
approved these changes
Oct 16, 2024
Contributor
gschorcht
left a comment
gschorcht
left a comment
There was a problem hiding this comment.
Tanks for improving the make system for ESP32x SoCs 😄
benpicco
added
Type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR improves the error messages of the esp32 common makefiles when adding new esp32 based boards/cpu.
The previous error messages did not make it clear which part was still missing when adding a new esp32 based board/cpu variant, thus making it needlessly complicated to pinpoint the problem (and also had a minor spelling mistake).
This also fixes the same spelling mistake for the cortexm error message.
Testing procedure
I tested the hello_world on both
nativeandesp32c3-devkitand also while adding a new variant to theesp32family. In all three cases everything worked as expected and it helped me to locate issues while adding a new variant.Issues/PRs references