CI: fix true and false positives by newer codespell version#20899
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Oct 9, 2024
Merged
CI: fix true and false positives by newer codespell version#20899maribu merged 2 commits intoRIOT-OS:masterfrom
maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
mguetschow
requested review from
PeterKietzmann,
gschorcht,
jia200x and
miri64
as code owners
github-actions
bot
added
Area: network
maribu
approved these changes
Oct 9, 2024
mguetschow
added
the
CI: ready for build
Contributor
Author
|
Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The static tests have been failing on
masterfor some time due to codespell findings: https://github.com/RIOT-OS/RIOT/actions/workflows/static-test.ymlThat happened probably after some update to the
riot/riotbuilddocker image, which presumably lead to a version bump of codespell.This PR adds some new false positives to the ignored-words list and fixes several found true positives throughout the codebase.
Testing procedure
Review typo corrections and newly added false positives.
Static tests in this PR will probably run through anyway as for all the other recent PRs. I'm wondering if the static-test workflow somehow uses a cached version of
riot/static-test-tools:latest, since pulling that and executing the codespell check locally there also fails.