Merged
Conversation
This patch exports the make macro `DEVELHELP`. Without this patch, use of the macro in the following files does not work when the macro is set in a makefile (such as in Makefile.local or an application's makefile as demonstrated in dist/Makefile). Inside these files `DEVELHELP` is not defined under these conditions. - pkg/littlefs/Makefile - pkg/littlefs2/Makefile - sys/stdio_null/Makefile Note that use of the macro does work in these files when the macro is set from the command line, without the patch. For example: ``` sh $make DEVELHELP=1 all ```
Contributor
Author
|
Please note that I have a change in-mind that can remove the use of |
Member
|
This PR:
So indeed, the warning from |
maribu
approved these changes
Oct 9, 2024
mguetschow
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch exports the make macro
DEVELHELP. Without this patch, use of the macro in the following files does not work when the macro is set in a makefile (such as in Makefile.local or an application's makefile as demonstrated in dist/Makefile). Inside these filesDEVELHELPis not defined under these conditions.Note that use of the macro does work in these files when the macro is set from the command line, without the patch. For example:
$make DEVELHELP=1 allTesting procedure
make -C examples/hello-world/ USEMODULE+=stdio_nullMakefile:2: STDIO disabled via stdio_null, but DEVELHELP enabledis seen with this patch, and is not seen without the patch. The warning is being emmited from the filesys/stdio_null/MakefileIssues/PRs references