Skip to content

gnrc_sixlowpan_frag: enable gnrc_netif_pktq if netdev_new_api is used#20879

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
benpicco:gnrc_sixlowpan_frag-gnrc_netif_pktq
Sep 30, 2024
Merged

gnrc_sixlowpan_frag: enable gnrc_netif_pktq if netdev_new_api is used#20879
maribu merged 1 commit intoRIOT-OS:masterfrom
benpicco:gnrc_sixlowpan_frag-gnrc_netif_pktq

Conversation

@benpicco
Copy link
Copy Markdown
Contributor

@benpicco benpicco commented Sep 30, 2024

Contribution description

6lowpan fragmentation is broken on at86rf215 since #20672. The driver no longer tries to block when a transfer is ongoing, but reports -EBUSY to the upper layer when a send is triggered while the previous frame is still being sent.

For this to work (and not drop the 2nd fragment), we need gnrc_netif_pktq.

Testing procedure

6lo fragmented packets are working again

2024-09-30 12:00:50,928 # > ping -s 512 fe80::6419:e83f:8e6b:4ce7%7
2024-09-30 12:00:51,042 # 520 bytes from fe80::6419:e83f:8e6b:4ce7%7: icmp_seq=0 ttl=64 rssi=-40 dBm time=108.982 ms
2024-09-30 12:00:52,050 # 520 bytes from fe80::6419:e83f:8e6b:4ce7%7: icmp_seq=1 ttl=64 rssi=-40 dBm time=108.986 ms
2024-09-30 12:00:53,044 # 520 bytes from fe80::6419:e83f:8e6b:4ce7%7: icmp_seq=2 ttl=64 rssi=-39 dBm time=108.983 ms
2024-09-30 12:00:53,045 # 
2024-09-30 12:00:53,058 # --- fe80::6419:e83f:8e6b:4ce7%7 PING statistics ---
2024-09-30 12:00:53,061 # 3 packets transmitted, 3 packets received, 0% packet loss
2024-09-30 12:00:53,063 # round-trip min/avg/max = 108.982/108.983/108.986 ms

Issues/PRs references

@benpicco benpicco requested a review from maribu September 30, 2024 10:59
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Sep 30, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 30, 2024
@riot-ci
Copy link
Copy Markdown

riot-ci commented Sep 30, 2024 •
edited
Loading

Murdock results

✔️ PASSED

0b99d4f gnrc_sixlowpan_frag: enable gnrc_netif_pktq if netdev_new_api is used

Success Failures Total Runtime
10197 0 10197 13m:50s

Artifacts

@miri64
Copy link
Copy Markdown
Member

miri64 commented Sep 30, 2024

6lowpan fragmentation is broken on at86rf215 since #20672.

How does link to gnrc_lorawan? The device is an IEEE 802.15.4 one and with LoRaWAN SCHC is recommended instead of 6LoWPAN.

@benpicco benpicco force-pushed the gnrc_sixlowpan_frag-gnrc_netif_pktq branch from 69d2af7 to 0b99d4f Compare September 30, 2024 12:08
@benpicco benpicco changed the title gnrc_lorawan: enable gnrc_netif_pktq if netdev_new_api is used gnrc_sixlowpan_frag: enable gnrc_netif_pktq if netdev_new_api is used Sep 30, 2024
@benpicco
Copy link
Copy Markdown
Contributor Author

benpicco commented Sep 30, 2024

Oops, copy & paste error on the commit title

maribu
maribu approved these changes Sep 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for spotting this!

@maribu maribu enabled auto-merge September 30, 2024 14:00
@maribu maribu added this pull request to the merge queue Sep 30, 2024
Merged via the queue into RIOT-OS:master with commit 4f15523 Sep 30, 2024
@benpicco benpicco deleted the gnrc_sixlowpan_frag-gnrc_netif_pktq branch October 1, 2024 07:50
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

Assignees

No one assigned

Labels

Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benpicco @riot-ci @miri64 @maribu