event/timeout: event_timeout_set() enqueues immediately if timeout is zero#20870
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Sep 25, 2024
Merged
event/timeout: event_timeout_set() enqueues immediately if timeout is zero#20870benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Currently, the following can result in
event_Bbeing executed beforeevent_A:I think this is unexpected behavior. Queuing an event with timeout zero should schedule the event for immediate execution. I therefore added a check in
event_timeout_set()to immediately queue if the timeout is zero.Testing procedure
I briefly tested this on native in the application I'm currently working on.