Merged
Conversation
Wer-Wolf
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
github-actions
bot
added
Area: tests
When psa_status_t is defined inside crypto_types.h, then all users of psa_status_t are forced to pull the full range of PSA Crypto API type definitions. This however means that psa_status_t cannot be used when defining those PSA Crypto API types, since doing so would create a cycle. Fix this by moving the PSA status definitions into a separate header file which additionally is compatible with the PSA Status code API. Signed-off-by: Armin Wolf <[email protected]>
The PSA crypto specification states that when creating keys, the usage flags PSA_KEY_USAGE_SIGN_HASH/PSA_KEY_USAGE_VERIFY_HASH automatically set the usage flags PSA_KEY_USAGE_SIGN_MESSAGE/PSA_KEY_USAGE_VERIFY_MESSAGE on the key. Signed-off-by: Armin Wolf <[email protected]>
Wer-Wolf
force-pushed
the
psa-headers
branch
from
9e1cf6f to
3ba57d6
Compare
benpicco
added
CI: ready for build
Wer-Wolf
force-pushed
the
psa-headers
branch
from
3ba57d6 to
a66dd5c
Compare
Einhornhool
reviewed
Sep 10, 2024
mguetschow
approved these changes
Sep 16, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks, LGTM, too! Just two comments below.
Add some tests to verify that when creating or importing keys, the usage flags PSA_KEY_USAGE_SIGN_HASH/PSA_KEY_USAGE_VERIFY_HASH automatically set the usage flags PSA_KEY_USAGE_SIGN_MESSAGE/ PSA_KEY_USAGE_VERIFY_MESSAGE on the key. Signed-off-by: Armin Wolf <[email protected]>
The initial implementation was inspired by MbedTLS, with the addition of the MD2 and MD4 algorithms. Signed-off-by: Armin Wolf <[email protected]>
This support macro is necessary for full MAC support. Signed-off-by: Armin Wolf <[email protected]>
Wer-Wolf
force-pushed
the
psa-headers
branch
from
a66dd5c to
fe56b7d
Compare
Contributor
Author
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes some bugs and missing features found during implementing a generic HMAC backend.
Since those fixes are not directly connected to the generic HMAC, it would make sense to merge them separatly.
Testing procedure
The changes where tested using the psa_crypto test where applicable.
Issues/PRs references
See #20758.