sys/net/application_layer/nanocoap: add nanocoap_sock_get_non()#20852
Merged
Teufelchen1 merged 3 commits intoRIOT-OS:masterfrom Sep 10, 2024
Merged
sys/net/application_layer/nanocoap: add nanocoap_sock_get_non()#20852Teufelchen1 merged 3 commits intoRIOT-OS:masterfrom
nanocoap_sock_get_non()#20852Teufelchen1 merged 3 commits intoRIOT-OS:masterfrom
Conversation
fabian18
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
leandrolanzieri and
miri64
as code owners
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
benpicco
reviewed
Sep 5, 2024
Teufelchen1
reviewed
Sep 6, 2024
benpicco
changed the title
nanocoap_sock_get_non()
benpicco
approved these changes
Sep 9, 2024
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Looks good to me, feel free to squash
fabian18
force-pushed
the
nanocoap_sock_get_non
branch
from
e66f2b1 to
be84af2
Compare
fabian18
force-pushed
the
nanocoap_sock_get_non
branch
from
be84af2 to
02e513e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
We have NON-Confirmable versions for PUT, POST, and FETCH, but non for GET so far.
This PR adds it in a straight forward manner.
Testing procedure
tapsetupTwo
nativeinstances oftests/net/nanocoap_cli.One starts the server:
The other one GETs a resource:
Issues/PRs references