sys/event: add assertion that event has a handler#20847
Merged
Teufelchen1 merged 5 commits intoRIOT-OS:masterfrom Oct 25, 2024
Merged
sys/event: add assertion that event has a handler#20847Teufelchen1 merged 5 commits intoRIOT-OS:masterfrom
Teufelchen1 merged 5 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
PeterKietzmann,
kaspar030 and
miri64
as code owners
benpicco
added
the
Type: enhancement
github-actions
bot
added
Area: network
benpicco
added
the
CI: ready for build
Teufelchen1
reviewed
Sep 25, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
Overall looks good, would you mind reminding me if I have not come around for a proper review in a couple weeks?
Teufelchen1
approved these changes
Oct 21, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
LGTM. Any specific reason you omitted an assert(cb) in callback.c event_callback_init(..)?
Contributor
Author
|
A callback struct with a NULL handler does no harm in itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When an uninitialized event is added, we will dereference a NULL pointer.
It can then be a bit tricky to find out which event caused this - so add an assertion when queuing the event that a callback is set.
Testing procedure
Issues/PRs references