Merged
Conversation
krzysztof-cabaj
force-pushed
the
nucleo-l452re-ADC
branch
from
80ffbb8 to
85e028a
Compare
Contributor
|
I think you have to rebase the PR, it does not include your previous fix yet. (Doesn't matter for the merge though, just makes testing more complicated.) I rebased it locally and can confirm it is still working as it should :) |
crasbe
reviewed
Jul 5, 2024
krzysztof-cabaj
force-pushed
the
nucleo-l452re-ADC
branch
from
85e028a to
fe4a764
Compare
krzysztof-cabaj
force-pushed
the
nucleo-l452re-ADC
branch
from
fe4a764 to
02ecded
Compare
Contributor
Author
|
@crasbe thanks for valuable comments. I |
Contributor
|
@krzysztof-cabaj Thank you for doing this PR even though you don't have an L452RE Nucleo :) |
dylad
added
the
CI: ready for build
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds to the Nucleo-l452re ADC configuration.
Testing procedure
Flash the board using
tests/periph_adcprogram. Check if measured values changes when A0-A5 pins areconnected to the 3,3V, GND or to the potentiometer.
Solution was successfully tested by @crasbe - more details PR #20756.
Issues/PRs references
PR #20756