tests/drivers/pn532: fix init error handling and increase verbosity#20750
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Jun 14, 2024
Merged
tests/drivers/pn532: fix init error handling and increase verbosity#20750benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
pn532_init()contains no logic to actually test the proper connection to the device, and the driver test ignores initialization failures and does not show comprehensive errors. This PR changes the test to abort on errors during initialization or fw-version retrieval.Testing procedure
Look through the code changes. This does not impact the test execution in case of no errors.