Remove extraneous bitwise assignment operation on NRF5X_common gpio.c#20737
Remove extraneous bitwise assignment operation on NRF5X_common gpio.c#20737dylad merged 1 commit intoRIOT-OS:masterfrom steverpalmer:master
Conversation
|
Thanks for your PR ! |
|
@dylad I've made the change as requested (I hope). I've also search every file in the codebase looking for lines that include the character sequences "INTENSET" and "|=" and not found any. Of course, such searches are no guarantee, but I doubt that this is a systemic issue across the code base, just a bit of muscle-memory gone wrong in this one file. Saves another 16 bytes ;-) |
|
@steverpalmer this looks good to me. |
|
Hopefully now squashed. |
|
Great ! One last thing I promise. |
|
Third attempt luck? Cheers. |
|
Thanks for your fix ! |
Contribution description
Removing an extraneous bitwise assignment operation for NRF5X_common gpio.c
Testing procedure
I've been running this on my micro-bit v2 with this fix for a couple of days with no ill effects. However, it is not expected that the changed the behaviour of the code at all.
On my code base, it saves a whole 16 bytes of code :-).
Issues/PRs references
Fixes #20736