dist/tools/buildsystem_sanity_check: make shellcheck happy#20721
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Jun 7, 2024
Merged
Conversation
maribu
added
Area: build system
github-actions
bot
added
Area: tools
maribu
commented
Jun 4, 2024
1 task
maribu
force-pushed
the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
from
0b47100 to
10afe6f
Compare
benpicco
reviewed
Jun 4, 2024
Member
Author
|
It looks like Github annotation is broken, and likely was never working here. I'll try to fix this as well first and mark this as ready when it works. |
maribu
force-pushed
the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
from
10afe6f to
28c3296
Compare
mguetschow
reviewed
Jun 5, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
LGTM, but mind that I'm not really an expert on bash scripts. Therefore only a soft-ACK.
Member
Author
|
Maybe @miri64 could give this a second look? The github annotations were tested in #20472 (comment) (that is a warning that is not part of this PR, but that warning is generated via the |
maribu
force-pushed
the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
from
231861a to
05d3303
Compare
miri64
reviewed
Jun 7, 2024
maribu
force-pushed
the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
from
05d3303 to
c282e5a
Compare
Member
Author
|
All green, just needs an ACK 😉 |
miri64
approved these changes
Jun 7, 2024
miri64
reviewed
Jun 7, 2024
The build system sanity check test script currently does not pass shellcheck, preventing PRs improving it from getting merged. In addition, the github annotation was broken. This commit fixes the issues pointed out by shellcheck as well as the Github annotation. Co-authored-by: mguetschow <[email protected]>
maribu
force-pushed
the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
from
c282e5a to
098167a
Compare
maribu
deleted the
dist/tools/buildsystem_sanity_check/make-shellcheck-happy
branch
Member
Author
|
Thx :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The build system sanity check test script currently does not pass shellcheck, preventing PRs improving it from getting merged.
This commit fixes the issues pointed out by shellcheck and should not have any functional changes, except for the github annotation teardown now being reached after the call to
main.Testing procedure
The test script should work as before.
Issues/PRs references
None