cpu/saml1x: avoid the use of bitfield in register calls#20710
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom May 30, 2024
Merged
cpu/saml1x: avoid the use of bitfield in register calls#20710maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
Signed-off-by: Dylan Laduranty <[email protected]>
github-actions
bot
added
Platform: ARM
benpicco
approved these changes
May 29, 2024
dylad
added
the
CI: ready for build
Member
Author
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR replaces all calls of
foo->bar.bit.xyz = ABCDtofoo->bar.reg &= ABCDfor all SAML10/SAML11 MCUsThis should not have much impact on the code.
Testing procedure
A careful review.
CI should catch most of the failure but feel free to run some tests on hardware.
Issues/PRs references
see #20457