build system: clean up netif features#20700
Merged
mguetschow merged 4 commits intoRIOT-OS:masterfrom Jun 3, 2024
Merged
Conversation
maribu
added
Area: build system
github-actions
bot
added
Platform: native
maribu
force-pushed
the
features/netif-cleanup
branch
2 times, most recently
from
48094c9 to
b0465e2
Compare
In order to extend features based on provided features, we need to check contents of `FEATURES_PROVIDED`.
If a board already provided a netif_% feature (currently only netif_ethernet), the netif feature is automagically provided.
maribu
force-pushed
the
features/netif-cleanup
branch
from
b0465e2 to
6084727
Compare
Use periph_eth instead of esp_eth for the Ethernet peripheral on ESP MCUs for consistency
maribu
force-pushed
the
features/netif-cleanup
branch
from
6084727 to
53f952f
Compare
mguetschow
approved these changes
Jun 3, 2024
Contributor
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
LGTM, thank you! Just a minor documentation suggestion below.
If there is an Ethernet peripheral (periph_eth feature provided), we can conclude that an Ethernet network interface can be provided. Co-authored-by: mguetschow <[email protected]>
maribu
force-pushed
the
features/netif-cleanup
branch
from
0ec4a93 to
47f52bd
Compare
Member
Author
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
netif_%(currently onlynetif_ethernet, but more are to come) is provided, thenetiffeature is implicitly providednetiffeature from boards that already providenetif_ethernetis dropped, consequentlyesp_ethnow instead provideperiph_ethfor consistancyperiph_ethno longer need to providenetif_ethernetw5100,w5500,enc28j60,encx24j600, etc.) would still need to providenetif_ethernetby handFEATURES_PROVIDED += netif_ethernetis dropped, relying on it being added implicitlyTesting procedure
This should not change any generated binaries.
Issues/PRs references
Follow up to #20694