build system: rename ethernet feature into netif_ethernet#20694
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom May 27, 2024
Merged
build system: rename ethernet feature into netif_ethernet#20694maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
The `ethernet` feature has not yet been used, so renaming it should not cause any issue. The goal is to eventually have a number of `netif_<type>` features that would allow filtering boards by the time of connectivity the have.
github-actions
bot
added
Platform: native
maribu
added
Process: API change
1 task
Member
Author
|
I would be fine if #20695 would get ACKed in merged directly; which depends on and includes this one. |
Contributor
|
Looks like you missed some boards that use |
Member
Author
I think that should rather be renamed into I guess we eventually should have some common place where |
Member
Author
|
@benpicco Would you be fine with it if I tackle ESP as follow up? |
Contributor
|
sure if that makes things any simpler ¯\(ツ)/¯ |
Member
Author
|
Thx a bunch :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This renames the
ethernetfeature intonetif_ethernet. The goal is to eventually have a number ofnetif_<type>features that would allow filtering boards by the time of connectivity the have.Testing procedure
The
ethernetfeature has not yet been used, so renaming it should not cause any issue. The CI will test this, though.Issues/PRs references
None