nanocoap_fs: add nanoCoAP as VFS backend (remote CoAP fs)#20687
Merged
benpicco merged 9 commits intoRIOT-OS:masterfrom May 29, 2024
Merged
nanocoap_fs: add nanoCoAP as VFS backend (remote CoAP fs)#20687benpicco merged 9 commits intoRIOT-OS:masterfrom
benpicco merged 9 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
leandrolanzieri,
maribu and
miri64
as code owners
github-actions
bot
added
Area: network
maribu
reviewed
May 22, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
This PR is surprisingly small for the feature it provides :)
benpicco
added
the
CI: ready for build
maribu
approved these changes
May 28, 2024
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
lgtm. Maybe make the CI happy regarding the line length limit?
Contributor
Author
|
Thank you for the quick review! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
With
aiocoap-fileserver/nanocoap_fileserverwe can export a local fs via CoAP.This adds a module that does the opposite: Locally mount a remote filesystem that was exported via CoAP.
Testing procedure
aiocoap-fileserverin a directory of your choicetests/net/nanocoap_fs:Issues/PRs references
requires #20688 when
nanocoap_fileserveris used as the server.