pkg/tflite-micro: Update tflite-micro to latest version. requires update of pkg/flatbuffers as well. by FlapKap · Pull Request #20683 · RIOT-OS/RIOT

FlapKap · 2024-05-22T12:35:16Z

Contribution description

This PR updates tflite-micro to the the latest version. Since the current version in Riot OS is quite old, this has mandated some other changes and updates:
The included flatbuffers pkg and dist/tools have been updated to v23.5.26 as thats the one tflite-micro uses.
The patch files to fix cast-align errors have been updated
The mnist example have been updated with new locations for headers and i've replaced the AllOpsResolver with mutable_ops_resolver, since the former has been deprecated. This requires the user to specify the exact operators needed, with an added bonus of a much smaller binary size.

Testing procedure

run the tests/pkg/tflite-micro test

Issues/PRs references

aabadie · 2024-05-22T14:15:42Z

I tried to build locally and got this error:

"make" -C /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro -f /work/riot/RIOT/pkg/tflite-micro/tflite-micro.mk
In file included from /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro/micro_interpreter.cc:33:
/work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/schema/schema_utils.h:29:38: error: 'OperatorCodeT' does not name a type; did you mean 'OperatorCode'?
   29 | BuiltinOperator GetBuiltinCode(const OperatorCodeT *op_code);
      |                                      ^~~~~~~~~~~~~
      |                                      OperatorCode

Any idea what it could be?

aabadie · 2024-05-22T14:34:07Z

Using make clean all fixes the problem.

aabadie · 2024-05-22T14:57:04Z

Tested on native and nrf52840dk and it works! Good job!

aabadie · 2024-05-22T14:58:38Z

Can you prepend your 4 last commit messages with the right context ("pkg/tflite-micro: ", "pkg/flatbuffers: ") ?

FlapKap · 2024-05-22T15:12:28Z

Can you prepend your 4 last commit messages with the right context ("pkg/tflite-micro: ", "pkg/flatbuffers: ") ?

done!

I tried to build locally and got this error:

"make" -C /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro -f /work/riot/RIOT/pkg/tflite-micro/tflite-micro.mk
In file included from /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro/micro_interpreter.cc:33:
/work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/schema/schema_utils.h:29:38: error: 'OperatorCodeT' does not name a type; did you mean 'OperatorCode'?
   29 | BuiltinOperator GetBuiltinCode(const OperatorCodeT *op_code);
      |                                      ^~~~~~~~~~~~~
      |                                      OperatorCode

Any idea what it could be?

I encountered the same issue when i had generated the schema using a different version of flatc than required. Just using the schema_generated already in the repo fixed it.

riot-ci · 2024-05-22T16:11:23Z

Murdock results

✔️ PASSED

6d51de0 pkg/tflite-micro: remove trailing spaces

Success	Failures	Total	Runtime
10104	0	10105	17m:35s

Artifacts

Documentation preview

aabadie · 2024-05-23T18:20:49Z

Can you fix the check-commits check? https://github.com/RIOT-OS/RIOT/actions/runs/9207542826/job/25327831907?pr=20683#step:4:5.
A multi line commit message should make it:

pkg/flatbuffers: downgrade to v23.5.26

because that's what tflite-micro depends on

aabadie · 2024-05-24T09:08:19Z

Sorry to bother you again with 57abe1c
The commit message should be:

pkg/flatbuffers: downgrade to v23.5.26

because that's what tflite-micro depends on

format is: short description on the first line, blank line, extended description.

Because that's what tflite-micro depends on

FlapKap · 2024-05-24T09:58:29Z

Sorry to bother you again with 57abe1c The commit message should be:
pkg/flatbuffers: downgrade to v23.5.26

because that's what tflite-micro depends on
format is: short description on the first line, blank line, extended description.

Done. No worries. Maybe I just shouldn't have done this past midnight :)

pkg/tflite-micro/Makefile

pkg/tflite-micro/patches/0001-fix-private-descriptor.patch

aabadie · 2024-05-24T10:10:45Z

tests/pkg/tflite-micro/Makefile.ci

@@ -1,109 +1,29 @@
 BOARD_INSUFFICIENT_MEMORY := \
-    airfy-beacon \


This is removing too many boards to be right. I doubt all those removed boards have enough memory. nrf51dk has only 8kB of RAM.

I generated it through the RIOT/dist/tools/insufficient_memory/create_makefile.ci.sh script, but i must admit i don't have that board to test it on. Running BOARD=nrf51dk make -C tests/pkg/tflite-micro/ it builds fine, but I can't actually run it. The closest i have access to is a microbit, and this compiles and works on that

Co-authored-by: Alexandre Abadie <[email protected]>

FlapKap · 2024-05-26T18:57:38Z

Murdock timed out on compiling the test for arduino-mkrwan1300 after 300 seconds. It does compile on my machine, but it takes 6,5 minutes

maribu · 2024-05-28T07:34:07Z

I tried to build locally and got this error:

"make" -C /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro -f /work/riot/RIOT/pkg/tflite-micro/tflite-micro.mk
In file included from /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro/micro_interpreter.cc:33:
/work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/schema/schema_utils.h:29:38: error: 'OperatorCodeT' does not name a type; did you mean 'OperatorCode'?
   29 | BuiltinOperator GetBuiltinCode(const OperatorCodeT *op_code);
      |                                      ^~~~~~~~~~~~~
      |                                      OperatorCode

Any idea what it could be?

This is now also popping up in the CI every now and then. There seems to be a race condition.

FlapKap · 2024-05-28T09:34:07Z

I tried to build locally and got this error:

"make" -C /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro -f /work/riot/RIOT/pkg/tflite-micro/tflite-micro.mk
In file included from /work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/micro/micro_interpreter.cc:33:
/work/riot/RIOT/build/pkg/tflite-micro/tensorflow/lite/schema/schema_utils.h:29:38: error: 'OperatorCodeT' does not name a type; did you mean 'OperatorCode'?
   29 | BuiltinOperator GetBuiltinCode(const OperatorCodeT *op_code);
      |                                      ^~~~~~~~~~~~~
      |                                      OperatorCode

Any idea what it could be?

This is now also popping up in the CI every now and then. There seems to be a race condition.

The cause is that schema_generated.h is not using the proper flatc flags to generate the appropriate types. However, the tflite-micro repo already has the correct schema_generated.h so there is probably some funny stuff going on when make decide to regenerate it. I'll create a new PR with the fix.

EDIT: PR #20703

pkg/flatbuffers: update flatbuffers to version 2.34.1

ae35ff2

FlapKap requested review from MichelRottleuthner, aabadie and leandrolanzieri as code owners May 22, 2024 12:35

github-actions bot added Area: tests Area: tests and testing framework Area: build system Area: Build system Area: pkg Area: External package ports Area: tools Area: Supplementary tools labels May 22, 2024

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 22, 2024

pkg/flatbuffers: remove unneeded patch

8ff87e7

FlapKap force-pushed the update-tfmicro branch from 00c0011 to 90ddf32 Compare May 22, 2024 15:10

FlapKap force-pushed the update-tfmicro branch from 9fc8566 to a0d8a87 Compare May 23, 2024 22:33

FlapKap added 4 commits May 24, 2024 11:57

pkg/flatbuffers: downgrade to v23.5.26

410fd5a

Because that's what tflite-micro depends on

pkg/tflite-micro: Update tflite-micro to latest version

9c1e664

pkg/flatbuffers: update patch

1fe1729

pkg/tflite-micro: update Makefile.ci

2622478

FlapKap force-pushed the update-tfmicro branch from 221f6fa to 2622478 Compare May 24, 2024 09:57

aabadie reviewed May 24, 2024

View reviewed changes

pkg/tflite-micro/Makefile Outdated Show resolved Hide resolved

aabadie reviewed May 24, 2024

View reviewed changes

pkg/tflite-micro/patches/0001-fix-private-descriptor.patch Outdated Show resolved Hide resolved

aabadie reviewed May 24, 2024

View reviewed changes

pkg/tflite-micro: Remove commented out code

df5d9d4

Co-authored-by: Alexandre Abadie <[email protected]>

pkg/tflite-micro: remove trailing spaces

6d51de0

FlapKap force-pushed the update-tfmicro branch from 11cbf2c to 6d51de0 Compare May 24, 2024 11:44

aabadie approved these changes May 24, 2024

View reviewed changes

aabadie enabled auto-merge May 24, 2024 19:09

aabadie added this pull request to the merge queue May 24, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024

aabadie added this pull request to the merge queue May 27, 2024

Merged via the queue into RIOT-OS:master with commit 2f3c262 May 27, 2024

FlapKap mentioned this pull request May 28, 2024

pkg/tflite-micro: add proper options to flatc #20703

Merged

mguetschow added this to the Release 2024.07 milestone Jun 11, 2024

		@@ -1,109 +1,29 @@
		BOARD_INSUFFICIENT_MEMORY := \
		airfy-beacon \

Conversation

FlapKap commented May 22, 2024

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

aabadie commented May 22, 2024

Uh oh!

aabadie commented May 22, 2024

Uh oh!

aabadie commented May 22, 2024

Uh oh!

aabadie commented May 22, 2024

Uh oh!

FlapKap commented May 22, 2024

Uh oh!

riot-ci commented May 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

aabadie commented May 23, 2024

Uh oh!

aabadie commented May 24, 2024

Uh oh!

FlapKap commented May 24, 2024

Uh oh!

Uh oh!

Uh oh!

aabadie May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FlapKap May 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FlapKap commented May 26, 2024

Uh oh!

maribu commented May 28, 2024

Uh oh!

FlapKap commented May 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

riot-ci commented May 22, 2024 •

edited

Loading

aabadie May 24, 2024 •

edited

Loading

FlapKap May 24, 2024 •

edited

Loading

FlapKap commented May 28, 2024 •

edited

Loading