tree-wide: Introduce netif feature and use it#20682
tree-wide: Introduce netif feature and use it#20682mguetschow merged 2 commits intoRIOT-OS:masterfrom
Conversation
maribu
added
Type: bug
github-actions
bot
added
Platform: native
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks for that! I haven't compared the removed list of boards vs. added FEATURES_PROVIDED in detail, but I'd trust you to have done that thoroughly enough - in the end it is only relevant for apps/tests using the default board features.
Just a minor addition below.
|
Sounds good to me, I tested it with a dwm1001, an arduino nano 33 ble (and the sense one) and didn't notice any unexpected behavior on the default example. My only question is about the following line : RIOT/examples/default/Makefile Line 49 in 0641ab2 Since you added a feature it should be the same as this one I think : |
This gets rid of a long list of boards with network interfaces and instead let's boards (or MCUs with peripheral network interfaces) provide the netif feature. The apps that before used the long list are not depending on the feature instead (in case of the default example, this is an optional dependency). Co-authored-by: mguetschow <[email protected]> Co-authored-by: mewen.berthelot <[email protected]>
maribu
force-pushed
the
buildsystem/netif-feature
branch
from
5264a06 to
97a6543
Compare
Indeed! Good catch :) |
maribu
requested review from
MichelRottleuthner,
aabadie,
benpicco,
dylad,
gschorcht,
kYc0o and
leandrolanzieri
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
The ESP32 Ethernet Kit has only a single GPIO pin exposed to SAUL via `saul_gpio`, but that GPIO doubles as PHY clock input when `esp32_eth` is used. Hence, the `saul_gpio` dep should be optional and only kick in when `esp32_eth` is not used.
|
Looks like the The second commit fixes that issue. |
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Good catch, thanks @maribu!
4 participants
Contribution description
This gets rid of a long list of boards with network interfaces and instead let's boards (or MCUs with peripheral network interfaces) provide the netif feature.
The apps that before used the long list are not depending on the feature instead (in case of the default example, this is an optional dependency).
Testing procedure
Ideally, no change in binaries. There may be some boards that actually do have a network interface but were not listed in
Makefile.boards.netifthat now qualify as having a network interface, if the feature was provided on MCU level (only for peripheral netifs).Issues/PRs references
Partially fixes #20680