doc/doxygen: remove default value for search form#20681
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom May 21, 2024
Merged
doc/doxygen: remove default value for search form#20681miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
mguetschow
added
the
CI: ready for build
miri64
approved these changes
May 21, 2024
Member
miri64
left a comment
miri64
left a comment
There was a problem hiding this comment.
LGTM. Why the value was set, I am not sure anymore. As you said, I implemented this 7 years ago and did not touch it much. Most likely, there was some faulty behavior in Doxygen's HTML output.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The search input field on doc.riot-os-org is prefilled with
value="Search", instead of only using the HTMLplaceholderattribute. I think this was not the case until some recent doxygen version bump, but I am not sure since the corresponding JS-code has been part of the repo for seven years.Testing procedure
Open https://doc.riot-os.org on Firefox or Chrome, see that the search field is prefilled.
Compare to the CI generated doxygen, which should only use "Search" as placeholder value: https://ci.riot-os.org/results/534d783017ac45f0a2d217c67b876c9f/doc-preview/
Issues/PRs references
Pinging @miri64 as the original author of the js-code.