sys/psa_crypto: remove keysize determination from Kconfig files#20674
Merged
mguetschow merged 1 commit intoRIOT-OS:masterfrom May 16, 2024
Merged
sys/psa_crypto: remove keysize determination from Kconfig files#20674mguetschow merged 1 commit intoRIOT-OS:masterfrom
mguetschow merged 1 commit intoRIOT-OS:masterfrom
Conversation
mguetschow
added
the
CI: ready for build
Einhornhool
approved these changes
May 16, 2024
Contributor
Einhornhool
left a comment
Einhornhool
left a comment
There was a problem hiding this comment.
I'm fine with it.
I manually ran some of the psa tests and they pass.
benpicco
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
There were some left-overs from Kconfig dependency modeling (#20438) in the PSA crypto implementation, namely the determination of the maximum key size. This PR removes that and now also unconditionally sets the maximum key size in the C header file.
Testing procedure
Look at the changes, CI should do.
Issues/PRs references
Noted thanks to a discussion with @darthdrannel