code looks good to me,
could you provide some test results for evaluation

code looks good to me, could you provide some test results for evaluation

This output is generated when trying to send a frame from the CAN controller without connecting another node / terminating the bus. I kept trying sending multiple times a frame in order to keep the transmission error counter incrementing until it reaches 96 (limit to get the warning status, section 39.8.14 PSR register bit 6), then it turns into the error passive state as a transmitter

Maybe it would be useful to include the Tx/Rx errors counter into the debug output when an error is triggered

Maybe it would be useful to include the Tx/Rx errors counter into the debug output when an error is triggered

if there is a common interface (across all of our can drivers) 👍 else please not

if there is a common interface (across all of our can drivers) 👍 else please not

I mean adding to the _isr interface of the SAMD5x CAN, not in the application level

if there is a common interface (across all of our can drivers) 👍 else please not

I mean adding to the _isr interface of the SAMD5x CAN, not in the application level

if you think that will help and shorten debug sessions 👍

you are thinking of a

DEBUG_PRINTF(" can controller 1 counted: %d erorrs", dev->ERR_COUNT);

in the isr ?
(paraphrasing - i didn't look up the register name)

Murdock results

✔️ PASSED

31003bf tests/drivers/candev: add debug output concerning errors

Artifacts

• Documentation preview

you are thinking of a

DEBUG_PRINTF(" can controller 1 counted: %d erorrs", dev->ERR_COUNT);

in the isr ? (paraphrasing - i didn't look up the register name)

Yes that's what I'm proposing, just showcasing the errors counter directly from the CAN register

Yes that's what I'm proposing, just showcasing the errors counter directly from the CAN register

waiting for this and will approve the PR then

@kfessel have your change requests been addressed?