pkg/wakaama: implement IPSO sensor objects in LwM2M#20652
Merged
leandrolanzieri merged 7 commits intoRIOT-OS:masterfrom Jun 7, 2024
Merged
pkg/wakaama: implement IPSO sensor objects in LwM2M#20652leandrolanzieri merged 7 commits intoRIOT-OS:masterfrom
leandrolanzieri merged 7 commits intoRIOT-OS:masterfrom
Conversation
6eaf99e to
c1713e5
Compare
Contributor
|
Cool! There are some merge conflicts and static white space issues. |
c1713e5 to
527cab6
Compare
Contributor
Author
I fixed the conflicts and ran uncrustify on all files. Yes, this is ready for review :) |
Teufelchen1
reviewed
Jun 4, 2024
Contributor
Teufelchen1
left a comment
There was a problem hiding this comment.
LGTM! Some static tests are not happy with your whitespace.
Contributor
Author
|
Hope I got all now |
071ae29 to
3d96491
Compare
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds implementations for various IPSO sensor objects to LwM2M. This is (hopefully) a first step towards automatically exposing SAUL devices to LwM2M. The implemented objects are:
Given that all objects share common properties and functionalities, there's a base IPSO sensor object that is used by the specific object implementations. The base implementation deals with resource access and instance allocation.
Testing procedure
All objects include documentation on their usage, you can include that code on
examples/lwm2mto test.Issues/PRs references
None