sys/shell: add support for running a batch of commands from a file#20651
Merged
benpicco merged 5 commits intoRIOT-OS:masterfrom May 15, 2024
Merged
sys/shell: add support for running a batch of commands from a file#20651benpicco merged 5 commits intoRIOT-OS:masterfrom
benpicco merged 5 commits intoRIOT-OS:masterfrom
Conversation
benpicco
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
github-actions
bot
added
Area: tests
benpicco
force-pushed
the
shell_scripting
branch
4 times, most recently
from
0603255 to
fc0b58a
Compare
benpicco
added
the
CI: ready for build
benpicco
force-pushed
the
shell_scripting
branch
2 times, most recently
from
90287a8 to
c86095e
Compare
fabian18
reviewed
May 14, 2024
fabian18
approved these changes
May 15, 2024
Contributor
fabian18
left a comment
fabian18
left a comment
There was a problem hiding this comment.
Please squash. I think it is good. Only think about if you want to keep or drop vfs_file_exists(). It is not used here anymore, but could still be useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This was requested for easier integration testing: It allows to provide a fixed (
native) binary that is able to execute shell commands provided by a file and terminate when it finished executing the commands (with an error code indicating success).Testing procedure
A simple test application is provided in
tests/sys/shell_scripting.Issues/PRs references