drivers: Adapt old platforms to periph rtc by OlegHahm · Pull Request #2060 · RIOT-OS/RIOT

OlegHahm · 2014-11-20T17:06:08Z

I guess the implementation could need some cleanup and more documentation.

NOTE: the TI cc430 can only set alarms based on minutes, hours and days of week - not on seconds, day of month, day of year, month or year.

OlegHahm · 2014-11-20T17:06:52Z

Depends on #1922.

LudwigKnuepfer · 2014-11-20T17:25:52Z

remove this

The discussion in #2046 converged (from my point of view) to the point that auto_init should not work on peripheral devices.

In any case - this PR does not change auto_init to do that (at least not yet).

LudwigKnuepfer · 2014-11-21T08:41:38Z

file does not have a C++ compatible header: 'boards/msb-430/include/periph_conf.h'

Won't fix. This check is stupid for empty files.

Then please come up with a method for the test to verify that the file is indeed empty.

OlegHahm · 2014-11-21T21:24:51Z

Depends also on #2061.

OlegHahm · 2014-11-21T22:24:00Z

Closes #10 - by removing the function. ;-)

LudwigKnuepfer · 2014-11-22T09:07:33Z

@OlegHahm are you OK with rebasing your PR on #2061 (which I in turn only base on #1922 after you say yes here)?

LudwigKnuepfer · 2014-11-22T10:38:34Z

Actually I will just do the change of base in #2061 .. you already said this PR depends on it sorry for the noise.

LudwigKnuepfer · 2014-11-24T14:47:49Z

Please squash and rebase on #2061 - then we can merge this (and the others with it) in one go.

OlegHahm · 2014-11-24T15:13:28Z

Did as you wished.

LudwigKnuepfer · 2014-11-24T15:24:38Z

hm, I think we need to rebase on something that has #2072 merged in order for Travis to be able to succeed.

mehlis · 2014-11-24T22:57:49Z

@OlegHahm nice work, the only ~~peace~~ piece of code that worked 1.5 years ago is gone now :( but it's replaced by a consistent API, so 👍

LudwigKnuepfer · 2014-12-15T10:48:51Z

The chronos board misses sscanf.
As the chronos has no uart0 implementation, this is somewhat silly.

LudwigKnuepfer · 2014-12-15T16:10:27Z

Please rebase on #2061 to satisfy chronos (even though theoretically useless). Might save some bytes for other platforms though.

OlegHahm · 2014-12-15T18:08:57Z

Did rebase.

LudwigKnuepfer · 2014-12-16T10:37:53Z

Apparently everything is fine now, so I will squash #2061 if you agree.

use strtol instead of sscanf use plain printf instead of asctime

The rtc module is deprecated and will be removed.

LudwigKnuepfer · 2014-12-16T15:58:25Z

needs rebase

Removes the old interface.

OlegHahm · 2014-12-16T16:03:15Z

reBASEd

LudwigKnuepfer · 2014-12-16T16:54:33Z

Do we really want to wait for Travis? It is awfully moody today.

OlegHahm · 2014-12-16T17:43:18Z

It's almost done.

LudwigKnuepfer · 2014-12-16T17:56:41Z

Done!

LudwigKnuepfer · 2014-12-16T17:56:48Z

ACK & go

drivers: Adapt old platforms to periph rtc

OlegHahm mentioned this pull request Nov 20, 2014

native periph rtc #1922

Merged

LudwigKnuepfer reviewed Nov 20, 2014
View reviewed changes

LudwigKnuepfer mentioned this pull request Nov 20, 2014

RTC shell command update #2061

Merged

LudwigKnuepfer reviewed Nov 21, 2014
View reviewed changes

OlegHahm force-pushed the periph_rtc branch from 6d97bd9 to 36e2a3a Compare November 21, 2014 13:30

OlegHahm force-pushed the periph_rtc branch from 72bbf51 to 4530c26 Compare November 21, 2014 22:27

LudwigKnuepfer mentioned this pull request Nov 22, 2014

drivers/rtc: mark as legacy #1919

Closed

LudwigKnuepfer self-assigned this Nov 24, 2014

LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Nov 24, 2014

OlegHahm force-pushed the periph_rtc branch from 4530c26 to b73cc46 Compare November 24, 2014 15:12

OlegHahm removed State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable labels Nov 24, 2014

OlegHahm force-pushed the periph_rtc branch from b73cc46 to 7d8230d Compare November 25, 2014 14:19

OlegHahm force-pushed the periph_rtc branch from 33d0475 to 3565c55 Compare December 15, 2014 17:23

Ludwig Ortmann added 6 commits December 16, 2014 15:41

native/rtc: define ENABLE_DEBUG, move include

474c8af

native/rtc: apply naming conventions

2ec0a1c

sys/shell: rewrite rtc command for periph/rtc

4942882

sys/shell: use more common libc calls

3729789

use strtol instead of sscanf use plain printf instead of asctime

examples/default: use periph/rtc instead of rtc

8ec1756

The rtc module is deprecated and will be removed.

sys/shell: refactor _parse_time

ca36e9c

OlegHahm added 8 commits December 16, 2014 17:02

boards: created periph-conf.h for remaining boards

ed54a57

cc430: lpc2387: switch to new periph/rtc interface

498edb1

Removes the old interface.

rtc: cleanup of lpc2387-rtc implementation

93cf446

cpu: remove superfluous gettimeofday functions

587920c

cpu: lpc2387: further rtc cleanup

849580a

periph_rtc: streamline lpc2387 and cc430 naming

60cd0d3

travis: make travis happy for empty header files

f7b1970

pttu: add periph_rtc also to this MSB-A2 variant

124c13b

OlegHahm force-pushed the periph_rtc branch from 3565c55 to 124c13b Compare December 16, 2014 16:02

LudwigKnuepfer removed the State: waiting for other PR State: The PR requires another PR to be merged first label Dec 16, 2014

LudwigKnuepfer pushed a commit that referenced this pull request Dec 16, 2014

Merge pull request #2060 from OlegHahm/periph_rtc

e7f6f64

drivers: Adapt old platforms to periph rtc

LudwigKnuepfer merged commit e7f6f64 into RIOT-OS:master Dec 16, 2014

OlegHahm deleted the periph_rtc branch December 16, 2014 18:02

Conversation

OlegHahm commented Nov 20, 2014

Uh oh!

OlegHahm commented Nov 20, 2014

Uh oh!

LudwigKnuepfer Nov 20, 2014

Choose a reason for hiding this comment

Uh oh!

OlegHahm Nov 20, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Nov 20, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Nov 20, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Nov 21, 2014

Choose a reason for hiding this comment

Uh oh!

OlegHahm Nov 21, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer Nov 25, 2014

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented Nov 21, 2014

Uh oh!

OlegHahm commented Nov 21, 2014

Uh oh!

LudwigKnuepfer commented Nov 22, 2014

Uh oh!

LudwigKnuepfer commented Nov 22, 2014

Uh oh!

LudwigKnuepfer commented Nov 24, 2014

Uh oh!

OlegHahm commented Nov 24, 2014

Uh oh!

LudwigKnuepfer commented Nov 24, 2014

Uh oh!

mehlis commented Nov 24, 2014

Uh oh!

LudwigKnuepfer commented Dec 15, 2014

Uh oh!

LudwigKnuepfer commented Dec 15, 2014

Uh oh!

OlegHahm commented Dec 15, 2014

Uh oh!

LudwigKnuepfer commented Dec 16, 2014

Uh oh!

LudwigKnuepfer commented Dec 16, 2014

Uh oh!

OlegHahm commented Dec 16, 2014

Uh oh!

LudwigKnuepfer commented Dec 16, 2014

Uh oh!

OlegHahm commented Dec 16, 2014

Uh oh!

LudwigKnuepfer commented Dec 16, 2014

Uh oh!

LudwigKnuepfer commented Dec 16, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants