sys/psa_crypto: SHA-{384,512/{224,256}}#20598
Merged
mguetschow merged 3 commits intoRIOT-OS:masterfrom May 17, 2024
Merged
Conversation
github-actions
bot
added
Area: doc
mguetschow
force-pushed
the
psa-hashes-sha512-truncated
branch
from
618010f to
b5acee7
Compare
mguetschow
added
the
CI: ready for build
Contributor
Author
|
Actually, let's defer this to after #20545, I'd get some more symlink interdependencies with this. |
4 tasks
mguetschow
force-pushed
the
psa-hashes-sha512-truncated
branch
from
b5acee7 to
43fb1dc
Compare
mguetschow
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
Contributor
Author
Einhornhool
approved these changes
May 16, 2024
Contributor
Einhornhool
left a comment
Einhornhool
left a comment
There was a problem hiding this comment.
LGTM, example passes on nRF52840dk and native.
benpicco
approved these changes
May 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mguetschow
force-pushed
the
psa-hashes-sha512-truncated
branch
from
43fb1dc to
6be95ca
Compare
Contributor
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Since #20484, RIOT contains software-implementations for the most commonly used truncated versions of SHA-512. This PR adds glue code to enable usage via the PSA Crypto API.
Sidenote: Although the nRF5 SDK documents support for SHA-384, it appears not to be supported on the nrf52840 CRYPTOCELL, as it returns
CRYS_HASH_ILLEGAL_OPERATION_MODE_ERROR. This is also confirmed in this thread. They also state that this board actually does not support SHA-512 in hardware either. Maybe it's worth disabling the periph feature for SHA-512 in that case, too?Testing procedure
Issues/PRs references
Second part of #20127, follow-up of #20484
There's also some interdependence with #20545, one of them should be updated after the other has been merged @Einhornhool
Closes #20127