cpu/esp: Handle format print errors#20596
Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom Apr 25, 2024
Merged
Conversation
github-actions
bot
added
Platform: ESP
Teufelchen1
added
the
CI: ready for build
mguetschow
reviewed
Apr 19, 2024
kfessel
reviewed
Apr 19, 2024
Teufelchen1
force-pushed
the
fix/esp_print
branch
from
7a96c93 to
a6ad8fc
Compare
kfessel
approved these changes
Apr 25, 2024
Contributor
kfessel
left a comment
kfessel
left a comment
There was a problem hiding this comment.
handles the vsnprintf output better than befor.
Teufelchen1
force-pushed
the
fix/esp_print
branch
from
a6ad8fc to
01e78ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hi 🦋
vsnprintfis not easy to use. This catches the error return and the truncation.Not sure if my approach is good as I am lacking context knowledge for that function.
Testing procedure
I don't know.
Issues/PRs references