Skip to content

sys/suit: return error when URL buffer is too small [backport 2024.01]#20563

Merged
maribu merged 1 commit intoRIOT-OS:2024.01-branchfrom
maribu:backport/2024.01/suit-ENOBUFS
Apr 10, 2024
Merged

sys/suit: return error when URL buffer is too small [backport 2024.01]#20563
maribu merged 1 commit intoRIOT-OS:2024.01-branchfrom
maribu:backport/2024.01/suit-ENOBUFS

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Apr 10, 2024

Backport of #20559

Contribution description

If we run production firmware and provide a manifest with a too large URL, don't crash with a hard to debug error, but return an error value instead.

Testing procedure

Issues/PRs references

GHSA-c4p4-vv7v-3hx8

@maribu maribu added Area: OTA Area: Over-the-air updates Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Apr 10, 2024
@maribu maribu requested a review from benpicco April 10, 2024 08:07
@riot-ci
Copy link
Copy Markdown

riot-ci commented Apr 10, 2024

Murdock results

✔️ PASSED

81a5f3a sys/suit: return error when URL buffer is too small

Success Failures Total Runtime
8612 0 8613 13m:19s

Artifacts

@maribu maribu added this pull request to the merge queue Apr 10, 2024
Merged via the queue into RIOT-OS:2024.01-branch with commit 86a8e1d Apr 10, 2024
@maribu maribu deleted the backport/2024.01/suit-ENOBUFS branch April 23, 2024 08:57
@mguetschow mguetschow added this to the Release 2024.07 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: OTA Area: Over-the-air updates Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants