sys/isrpipe/read_timeout: don't set up timer if data is available#20558
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Apr 9, 2024
Merged
sys/isrpipe/read_timeout: don't set up timer if data is available#20558benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
derMihai
force-pushed
the
mir/isrpipe_timeout
branch
from
73dd680 to
016f074
Compare
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Apr 8, 2024
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
looks good and makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
isrpipe_read_timeout()always sets a timer, adding unnecessary overhead for small, frequent reads (like in the AT driver). With this PR, a timer is set only if no data is available.Testing procedure
I tested this with the AT unit tests.