tests/sys/psa_crypto*: remove test symlinks#20545
Conversation
Einhornhool
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
MrKevinWeiss
added
the
CI: ready for build
|
There is also a label to disable the test cache if we need it. |
mguetschow
left a comment
mguetschow
left a comment
There was a problem hiding this comment.
Thanks for cleaning this up!
For some reason, Github doesn't let me comment on the lines directly, but in several main.c files, you still have
/* Needed in case only hashes are tested */
(void)status;
(void)start;
which is now superfluous, right?
Maybe it would also be a good idea to add a comment to the example_*.c files mentioning that they are copied from examples/psa_crypto.
Apart from that, LGTM :)
You're right. I updated the files :) |
|
You may then squash everything together 👍 |
Einhornhool
force-pushed
the
pr/psa-remove-test-symlinks
branch
from
23da36a to
2f98d21
Compare
Einhornhool
force-pushed
the
pr/psa-remove-test-symlinks
branch
from
2f98d21 to
a958332
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 participants
The PSA configuration tests used symlinks of the files from
examples/psa_crypto.This lead to the issue that CI did not rebuild them for each of the tests and missed some boards with insufficient memories.
This PR removes the symlinks from the tests and cleans up some of the code.
Testing procedure
Run the tests successfully for all boards.