cpu/sam0: Remove deprecated muxpos#20525
Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom May 7, 2024
Merged
Conversation
github-actions
bot
added
Platform: ARM
benpicco
reviewed
Apr 2, 2024
Teufelchen1
force-pushed
the
deprecate/muxpos
branch
2 times, most recently
from
f2e4c3b to
f0528df
Compare
Teufelchen1
added
the
CI: ready for build
Member
|
There are still some references to $ git grep -c "\<muxpos\>" boards/ cpu/
boards/adafruit-grand-central-m4-express/include/periph_conf.h:1
boards/adafruit-itsybitsy-m4/include/periph_conf.h:1
boards/adafruit-pybadge/include/periph_conf.h:1
boards/arduino-nano-33-iot/include/periph_conf.h:1
boards/bastwan/include/periph_conf.h:1
boards/common/arduino-mkr/include/periph_conf_common.h:1
boards/common/arduino-zero/include/periph_conf.h:1
boards/common/saml1x/include/periph_conf.h:1
boards/feather-m0/include/periph_conf.h:1
boards/hamilton/include/periph_conf.h:1
boards/samd10-xmini/include/periph_conf.h:1
boards/samd20-xpro/include/periph_conf.h:1
boards/samd21-xpro/include/periph_conf.h:1
boards/same54-xpro/include/periph_conf.h:1
boards/saml21-xpro/include/periph_conf.h:1
boards/samr21-xpro/include/periph_conf.h:1
boards/samr30-xpro/include/periph_conf.h:1
boards/samr34-xpro/include/periph_conf.h:1
boards/seeeduino_xiao/include/periph_conf.h:1
boards/sensebox_samd21/include/periph_conf.h:1
boards/serpente/include/periph_conf.h:1
boards/sodaq-autonomo/include/periph_conf.h:1
boards/sodaq-explorer/include/periph_conf.h:1
boards/sodaq-one/include/periph_conf.h:1
boards/sodaq-sara-aff/include/periph_conf.h:1
boards/sodaq-sara-sff/include/periph_conf.h:1
boards/yarm/include/periph_conf.h:1
cpu/sam0_common/include/periph_cpu_common.h:1
cpu/sam0_common/periph/adc.c:5(intentionally masking to |
mguetschow
requested changes
Apr 2, 2024
Teufelchen1
force-pushed
the
deprecate/muxpos
branch
from
f0528df to
1cb2d7c
Compare
Contributor
Author
|
@miri64 I stepped through your comments. I do not think they should be changed. The comments are not misleading. What I could do is to rename the defines and then adjust the comments: But again, I do not think that would be a great change... |
Member
|
following @miri64 's comment. There is a bunch of |
mguetschow
approved these changes
May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Hello 🪱
This removes the long 5843ff4 deprecated
adc_conf_chan_t::muxpos.Testing procedure
CI should be enough.
links
deprecated in #18688