gnrc_netif: remove deprecated CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR#20515
Merged
miri64 merged 3 commits intoRIOT-OS:masterfrom Mar 28, 2024
Merged
Conversation
miri64
requested review from
MrKevinWeiss,
PeterKietzmann and
leandrolanzieri
as code owners
github-actions
bot
added
Area: network
miri64
added
Type: cleanup
Teufelchen1
approved these changes
Mar 27, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
Trusting Miri... a lot. 😏
miri64
added
CI: ready for build
miri64
force-pushed
the
gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR
branch
from
1a444ba to
75dc4c8
Compare
Member
Author
|
Squashed |
miri64
force-pushed
the
gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR
branch
from
75dc4c8 to
a591ef1
Compare
Member
Author
|
And rebased. |
With the removal of `CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR` it does not use `GNRC_NETTYPE_LORAWAN` anymore, so this module is not required anymore.
miri64
force-pushed
the
gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR
branch
from
a591ef1 to
810f1a9
Compare
Member
Author
|
And another rebase... |
miri64
deleted the
gnrc_netif/cleanup/rm-CONFIG_GNRC_NETIF_LORAWAN_NETIF_HDR
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Deprecated since forever and was slated for removal after 2021.10. So let's do it now! As a consequence, I deprecated the now unused (at least in our codebase)
GNRC_NETTYPE_LORAWANand aliased it withGNRC_NETTYPE_UNDEF(and removed the dependency fromgnrc_lorawan).Testing procedure
Everything should still compile as before (in fact, the binary should even look the same, but did not confirm that).
Issues/PRs references
deprecated in #16080