gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send()#20514
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Mar 28, 2024
Merged
gcoap: make gcoap_req_send_tl() an alias of gcoap_req_send()#20514miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
As per the deprecation notice from July 2021 ;-).
miri64
added
Type: cleanup
github-actions
bot
added
Area: network
Teufelchen1
reviewed
Mar 27, 2024
Teufelchen1
approved these changes
Mar 27, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
Didn't test it but lgtm, trusting miri & CI
Member
Author
|
Seems unrelated |
miri64
added
CI: ready for build
mguetschow
added a commit
to mguetschow/RIOT
that referenced
this pull request
Apr 8, 2025
Use alias @ref gcoap_req_send() instead Deprecated in RIOT-OS#20514
mguetschow
added a commit
to mguetschow/RIOT
that referenced
this pull request
Apr 8, 2025
Use alias `gcoap_req_send()` instead Deprecated in RIOT-OS#20514
Lukas-Luger
pushed a commit
to Lukas-Luger/RIOT
that referenced
this pull request
Apr 14, 2025
Use alias `gcoap_req_send()` instead Deprecated in RIOT-OS#20514
AnnsAnns
pushed a commit
to AnnsAnns/RIOT
that referenced
this pull request
Apr 16, 2025
Use alias `gcoap_req_send()` instead Deprecated in RIOT-OS#20514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The deprecation notice for
gcoap_req_send_tl()says, it was supposed to be made an alias forgcoap_req_send()after the 2022.01 release. This never happened, so let's do that 2 years after ;-). As a consequence I bumped up the actual removal ofgcoap_req_send_tl()to after the 2024.10 release.Testing procedure
Should be straight forward, as
gcoap_req_send()was a wrapper aroundgcoap_req_send_tl()with the default parameterGCOAP_SOCKET_TYPE_UNDEFalready. As this adds that default parameter to all calls ofgcoap_req_send(), nothing should change. So compilation should catch any issues.Issues/PRs references