doc: Allow resizing of doxygen side-nav#20511
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Mar 27, 2024
Merged
Conversation
Currently it is not possible to resize the side-nav of the RIOT doxygen website in firefox. This is caused by the window resize_handler being called even for resizing inside the window. The resize_handler resets the side-nav to a cached size preventing resizing. This commit fixes this by checking if the window was actually resized.
mguetschow
added
the
CI: ready for build
maribu
approved these changes
Mar 27, 2024
Member
|
Thanks for the quick fix and congratulation for getting the first PR to RIOT upstream 🍰 |
Member
|
I was made aware that you already have contributed to riot-wrappers. Sorry for the confusion and thanks for the continuous help ❤️ |
miri64
added
CI: skip compile test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Fixes the bug that the side-nav on RIOT-doxygen website can not be resized (in Firefox) (See #20414).
Testing procedure
Open https://doc.riot-os.org/ and try to resize the side-nav on the left (using Firefox).
Issues/PRs references
Closes #20414