cpu/stm32: remove redundant conditional compile block#20495
Merged
aabadie merged 2 commits intoRIOT-OS:masterfrom Mar 22, 2024
Merged
cpu/stm32: remove redundant conditional compile block#20495aabadie merged 2 commits intoRIOT-OS:masterfrom
aabadie merged 2 commits intoRIOT-OS:masterfrom
Conversation
This patch removes a largely redundant block of conditional includes. The removed includes are moved into the family specific headers so that the more specific headers may override defaults defined in the shared headers.
github-actions
bot
added
Platform: ARM
Enoch247
commented
Mar 20, 2024
aabadie
added
the
CI: ready for build
Enoch247
changed the title
aabadie
approved these changes
Mar 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
aabadie
reviewed
Mar 21, 2024
Enoch247
force-pushed
the
simplify-stm32-clk-includes
branch
from
68df35b to
1e45261
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This patch removes a largely redundant block of conditional includes.
The removed includes are moved into the family specific headers so that the more specific headers may override defaults defined in the shared headers.
Testing procedure
The changes are paternalistic enough that it should be obvious in review if this breaks anything.
I did do:
and
Issues/PRs references
This relates to the work I am doing to port RIOT to the STM32H7 family.