treewide: remove deprecated shell_commands module#20485
treewide: remove deprecated shell_commands module#20485maribu merged 2 commits intoRIOT-OS:masterfrom
Conversation
Replaces it by shell_cmds_default where needed Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
dylad
added
the
CI: ready for build
dylad
requested review from
MichelRottleuthner,
aabadie,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: network
dylad
changed the title
dylad
added
the
Process: removal
| ifneq (,$(filter shell_commands,$(USEMODULE))) | ||
| # shell_commands has been renamed to shell_cmds_default, but let's keep this | ||
| # for backward compatibility | ||
| USEMODULE += shell_cmds_default | ||
| endif |
There was a problem hiding this comment.
Is this really necessary?
This will break all external apps, keeping those few lines around wouldn't hurt and avoid the churn on users.
There was a problem hiding this comment.
This module is deprecated for more than a year already. We were supposed to remove it after 2023.07 release according to makefiles/pseudomodules.inc.mk
I guess we give enough time to our users to migrate already.
This will break all external apps, keeping those few lines around wouldn't hurt and avoid the churn on users.
The question is do we want to keep backward compatibility forever ?
There was a problem hiding this comment.
I'm opting for removal. If your old app really needs it, you can still use old releases of RIOT.
(I also believe it is a good thing, to annoy your users to migrate to new APIs regularly, as long as it is done in a sensible manner. A bit like Apple does it. But that's clearly an personal opinion)
There was a problem hiding this comment.
I'm also in favor of removal, in the end that's what our yet-to-be-documented deprecation process is for.
|
I'm still in favor of removing long enough deprecated stuff. |
|
Thanks ! |
7 participants
Contribution description
This PR removes a deprecated module that should have been removed a few release ago.
I've replaced it by
shell_cmds_defaultwhere needed.Testing procedure
CI should be enough to catch up any miss.
Issues/PRs references
None.