sys/hashes: support for SHA-{384,512/{224,256}}#20484
Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom Mar 25, 2024
Merged
sys/hashes: support for SHA-{384,512/{224,256}}#20484Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Conversation
github-actions
bot
added
Area: tests
4 tasks
Teufelchen1
reviewed
Mar 20, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
🐈⬛ Looks good, very few comments!
Teufelchen1
added
the
CI: ready for build
Contributor
Author
|
Should be ready for another round of review. |
Teufelchen1
approved these changes
Mar 20, 2024
Contributor
Author
|
The last commit is a one-to-one translation of #19969 (comment). If Murdock runs through, may I squash? |
Contributor
|
Yes yes, please squash! |
pkg/esp32_sdk: rename sha384_init to avoid name clash
mguetschow
force-pushed
the
hashes-sha512-trunc
branch
from
5735bef to
9300007
Compare
Contributor
Author
|
Done :) |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds support for the most common truncated versions of SHA512 (SHA-512/224, SHA-512/256 and SHA-384), following the example of the SHA-224 implementation.
Testing procedure
Respective tests are added to unittests.
Issues/PRs references
First part of #20127