Skip to content

.murdock: document TESTS_BOARDS_LLVM_COMPILE#20482

Merged
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:murdock/llvm-comment
Mar 19, 2024
Merged

.murdock: document TESTS_BOARDS_LLVM_COMPILE#20482
maribu merged 1 commit intoRIOT-OS:masterfrom
maribu:murdock/llvm-comment

Conversation

@maribu
Copy link
Copy Markdown
Member

@maribu maribu commented Mar 19, 2024

Contribution description

The comment above TESTS_BOARDS_LLVM_COMPILE is misleading and outdated. This is due to an oversight in 52cf2b4 where tests on LLVM where re-enabled.

This drops the old comment and instead adds a comment why only a subset of boards are build on LLVM.

Testing procedure

Read the comment added. This changes no code, so no breaking in the CI or on hardware is expected.

Issues/PRs references

Reported in #15595 (comment)

The comment above TESTS_BOARDS_LLVM_COMPILE is misleading and
outdated. This is due to an oversight in
52cf2b4 where tests on LLVM where
re-enabled.

This drops the old comment and instead adds a comment why only a
subset of boards are build on LLVM.
@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Mar 19, 2024
@maribu maribu requested a review from kaspar030 as a code owner March 19, 2024 12:56
@github-actions github-actions bot added Area: CI Area: Continuous Integration of RIOT components and removed Area: doc Area: Documentation labels Mar 19, 2024
@maribu maribu mentioned this pull request Mar 19, 2024
Copy link
Copy Markdown
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@maribu maribu enabled auto-merge March 19, 2024 13:02
@riot-ci
Copy link
Copy Markdown

riot-ci commented Mar 19, 2024

Murdock results

✔️ PASSED

a4df903 .murdock: document TESTS_BOARDS_LLVM_COMPILE

Success Failures Total Runtime
1 0 1 10s

Artifacts

@maribu maribu added this pull request to the merge queue Mar 19, 2024
Merged via the queue into RIOT-OS:master with commit 21bd422 Mar 19, 2024
@maribu maribu deleted the murdock/llvm-comment branch March 19, 2024 22:57
@maribu
Copy link
Copy Markdown
Member Author

maribu commented Mar 19, 2024

Thx :)

@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants