nanocoap_sock: add support for IPv4#20476
Merged
maribu merged 2 commits intoRIOT-OS:masterfrom Mar 17, 2024
Merged
Conversation
benpicco
requested review from
PeterKietzmann,
maribu and
miri64
as code owners
github-actions
bot
added
Area: network
maribu
approved these changes
Mar 17, 2024
benpicco
added
the
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
NanoCOAP is already agnostic towards the IP version, but there is one part where the code checks if the destination address is link-local, to see if an interface id is needed.
Since there are no link-local addresses with IPv4, we can simply not do that in the v4 only case.
Testing procedure
Build an LWIP IPv4 application with the
nanocoap_vfsmodule (and default shell commands)Issues/PRs references