cpu/rpx0xx: add initial pwm support#20473
Merged
dylad merged 3 commits intoRIOT-OS:masterfrom Mar 19, 2024
Merged
Conversation
dylad
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
github-actions
bot
added
Area: boards
Member
Author
|
With a logic analyzer attached and the following commands: Here are the results: |
kfessel
reviewed
Mar 18, 2024
kfessel
reviewed
Mar 18, 2024
Contributor
kfessel
left a comment
kfessel
left a comment
There was a problem hiding this comment.
reads good, test results provided
please squash your fixups
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
dylad
force-pushed
the
cpu/rpx0xx/pwm_support
branch
from
9092d9a to
8b84fc5
Compare
Member
Author
|
Rebased and squashed. |
dylad
added
the
CI: ready for build
kfessel
approved these changes
Mar 18, 2024
Member
Author
|
Thanks for the review @kfessel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR adds an initial PWM peripheral driver for RP2040-based board.
PWM IP block is feed by the system clock (fixed) so it is not very flexible but it works as intended.
So far I've only add the LED pin as PWM as it is convenient to check with the
oscicommand fromtests/periph/pwmHowever, I've also tested locally other pins to check the overall logic.
Testing procedure
Play with
tests/periph/pwmonrpi-picofor instance.Issues/PRs references
None.