treewide: remove deprecated modules#20471
Merged
dylad merged 11 commits intoRIOT-OS:masterfrom Mar 19, 2024
Merged
Conversation
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
dylad
added
the
Process: removal
github-actions
bot
added
Area: network
kfessel
added
the
CI: ready for build
Contributor
|
seems like murdock found a reason :) @dylad please check failing testes |
maribu
reviewed
Mar 18, 2024
sys/shell/doc.txt
Outdated
| A few rarely needed shell commands that needs to be used in addition to the | ||
| `shell_commands` and the module providing the C-API. Examples include `nice`, | ||
| `gnrc_udp_cmd`, or `random_cmd`. Consult the documentation of the modules to | ||
| `shell_cmd_gnrc_udp`, or `random_cmd`. Consult the documentation of the modules to |
Member
There was a problem hiding this comment.
Suggested change
| `shell_cmd_gnrc_udp`, or `random_cmd`. Consult the documentation of the modules to | |
| `shell_cmd_gnrc_udp`, or `shell_cmd_random`. Consult the documentation of the modules to |
Member
Author
There was a problem hiding this comment.
Done, also update the nice to shell_cmd_nice the line above while at it.
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
Signed-off-by: Dylan Laduranty <[email protected]>
dylad
force-pushed
the
pr/treewide/remove_deprecation
branch
from
396940d to
05220c6
Compare
dylad
requested review from
MichelRottleuthner,
aabadie and
leandrolanzieri
as code owners
Member
Author
|
@kfessel I think CI should be happy now. I also squashed at the same time. |
kfessel
approved these changes
Mar 18, 2024
Contributor
kfessel
left a comment
kfessel
left a comment
There was a problem hiding this comment.
well past their due for removal
Member
Author
|
Thanks for the reviews ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes a bunch of deprecated modules that I found while looking at the
makefiles/pseudomodules.inc.mkso I guess it is time to do some cleanup.There are still some deprecated modules in the wild, but they will need a little bit more attention so I think it is better if this is done in another PR.
Testing procedure
I think CI should be enough but you could run a quick
grepto ensure I didn't forget something.Issues/PRs references
None.