Skip to content

examples/psa_crypto: Fix modules to run ECDSA on SEs#20461

Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Einhornhool:pr/run-ecdsa-functions-with-secure-elements
Mar 12, 2024
Merged

examples/psa_crypto: Fix modules to run ECDSA on SEs#20461
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom
Einhornhool:pr/run-ecdsa-functions-with-secure-elements

Conversation

@Einhornhool
Copy link
Copy Markdown
Contributor

@Einhornhool Einhornhool commented Mar 12, 2024 •
edited
Loading

Contribution description

There was an error in the compile time conditionals that did not consider secure elements.
This means that when running the example with a secure element, the ECDSA functions were not executed anymore.

This provides a fix for that.

Testing procedure

When running SECURE_ELEMENT=1 BOARD=nrf52840dk make flash term on master

2024-03-12 14:23:31,097 # main(): This is RIOT! (Version: 2024.01-devel-1054-g03c05f-pr/run-ecdsa-functions-with-secure-elements)
2024-03-12 14:23:31,098 # HMAC SHA256 took 56402 us
2024-03-12 14:23:31,098 # Cipher AES 128 took 68853 us
2024-03-12 14:23:31,099 # All Done
2024-03-12 14:25:03,072 # Exiting Pyterm

After applying these changes:

2024-03-12 14:41:09,059 # main(): This is RIOT! (Version: 2024.01-devel-1054-g03c05f-pr/run-ecdsa-functions-with-secure-elements)
2024-03-12 14:41:09,060 # HMAC SHA256 took 56535 us
2024-03-12 14:41:09,060 # Cipher AES 128 took 68973 us
2024-03-12 14:41:09,061 # ECDSA took 282086 us
2024-03-12 14:41:09,061 # All Done
2024-03-12 14:41:17,151 # Exiting Pyterm

Issues/PRs references

@github-actions github-actions bot added the Area: examples Area: Example Applications label Mar 12, 2024
Teufelchen1
Teufelchen1 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with real® hardware

@Teufelchen1 Teufelchen1 enabled auto-merge March 12, 2024 15:50
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 12, 2024
@riot-ci
Copy link
Copy Markdown

riot-ci commented Mar 12, 2024

Murdock results

✔️ PASSED

d8c003f examples/psa_crypto: Fix modules to run ECDSA on SEs

Success Failures Total Runtime
17 0 17 33s

Artifacts

@Teufelchen1 Teufelchen1 added this pull request to the merge queue Mar 12, 2024
Merged via the queue into RIOT-OS:master with commit 21875ef Mar 12, 2024
@Einhornhool Einhornhool mentioned this pull request Mar 13, 2024
Merged
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@mguetschow mguetschow mguetschow approved these changes

Assignees

No one assigned

Labels

Area: examples Area: Example Applications CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR

Projects

None yet

Milestone

Release 2024.04

Development

Successfully merging this pull request may close these issues.

6 participants

@Einhornhool @riot-ci @Teufelchen1 @mguetschow @benpicco @MrKevinWeiss