event_periodic_callback: add event_periodic_callback_create()#20459
Merged
mguetschow merged 2 commits intoRIOT-OS:masterfrom Mar 18, 2024
Merged
event_periodic_callback: add event_periodic_callback_create()#20459mguetschow merged 2 commits intoRIOT-OS:masterfrom
mguetschow merged 2 commits intoRIOT-OS:masterfrom
Conversation
Contributor
Do you have an example? Can you refactor some code? Reads fine, lgtm. |
Contributor
Author
I unfortunately can't since that's code by a customer, but I also want to spare your eyes. static void *_adc_thread(void *ctx)
{
(void)ctx;
while (1) {
do_measure();
send_data();
ztimer_sleep():
}
return NULL;
}If I can get them to instead do static void _adc_event(void *ctx)
{
do_measure();
send_data();
}that would be a win for everyone. |
Teufelchen1
approved these changes
Mar 12, 2024
Contributor
|
Ah, forgot to ask for squashing 😅 |
benpicco
added
the
CI: ready for build
Contributor
Author
|
eh but those are two distinct commits |
Contributor
|
well....if you insist 😀 |
Contributor
|
very convenient |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Creating a periodic event should be no more difficult than creating a thread, so add a
event_periodic_callback_create()convenience functions that reduces creating and starting a periodic event to a single function.Testing procedure
Read the API to see if this is really a worthwhile improvement.
Issues/PRs references
After seeing many threads being created for simple periodic measurements, maybe this could be a remedy.