drivers/rgbled: Remove driver#20407
Merged
Teufelchen1 merged 1 commit intoRIOT-OS:masterfrom Mar 19, 2024
Merged
Conversation
The driver is largely unused, and redundant with the saul_pwm_rgb_params functionality of SAUL.
chrysn
added
Area: drivers
chrysn
requested review from
MrKevinWeiss,
jia200x and
leandrolanzieri
as code owners
Teufelchen1
approved these changes
Mar 19, 2024
Contributor
Teufelchen1
left a comment
Teufelchen1
left a comment
There was a problem hiding this comment.
No notice from the pinged people in a month, I'll take over.
LGTM, less code, less bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
I just got asked by @maikerlab about how to use RGB LEDs from Rust, and to my surprise was pointed to https://doc.riot-os.org/group__drivers__rgbled.html.
That driver is completely unused (no examples, no tests, no mentions of its two functions in any other place of the code), and redundant with the saul_pwm_rgb_params functionality of SAUL.
Testing procedure