tests: disable flaky tests on native in the CI#20382
Merged
kaspar030 merged 2 commits intoRIOT-OS:masterfrom Feb 19, 2024
Merged
tests: disable flaky tests on native in the CI#20382kaspar030 merged 2 commits intoRIOT-OS:masterfrom
native in the CI#20382kaspar030 merged 2 commits intoRIOT-OS:masterfrom
Conversation
This tests fails sporadically on unrelated PRs, wasting days of CPU time in the CI. So, let's disable this test for now.
The test is already marked as disabled, but executed anyway. Hopefully this does the trick.
maribu
added
CI: ready for build
maribu
requested review from
MichelRottleuthner,
aabadie,
leandrolanzieri and
miri64
as code owners
maribu
added
CI: ready for build
Member
Author
|
There seems to be no |
kaspar030
approved these changes
Feb 19, 2024
Member
Author
|
Thx :) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
As the title says, this disables
tests/sys/ztimer_msg(example flaky failure) and tries to disabletests/net/gnrc_rplfor good, which was already marked as disabled.I theorize that the reason the RPL test was still run in the order of evaluation. Due to the default recursive definitions of variables in Makefile often the order of definition can change while still achieving the same result, except when the order does matter. This is a bit of an unfortunate default.
Testing procedure
In the CI the RPL test should not be run on native. (This has
CI: full buildset so that we can observe this even without hitting merge.)Issues/PRs references
None